add victor's comment

pulp-platform · Dec 13, 2024 · 0d4baed · 0d4baed
1 parent 27dff8c
commit 0d4baed
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 4 deletions.
diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml
@@ -103,9 +103,10 @@ jobs:
         testRQGEMM
         TestRQAdd
         testRQGEMMTransB
+      num-cores: 9
 
   snitch-kernels-tiled-singlebuffer-L2:
-    uses: ./.github/workflows/TestRunnerTiledSnitch.yml
+    uses: ./.github/workflows/TestRunnerTiledSnitchSequential.yml
     with:
       tests-config: |
         [

diff --git a/.github/workflows/TestRunnerSnitch.yml b/.github/workflows/TestRunnerSnitch.yml
@@ -6,6 +6,13 @@ on:
       test-names:
         required: true
         type: string
+      num-cores:
+        required: true
+        type: number
+      simulator:
+        required: false
+        default: "banshee"
+        type: string      
 
 jobs:
   test-runner-snitch:
@@ -26,7 +33,7 @@ jobs:
           echo "$testNames" | while IFS= read -r testName; do
             if [[ -n "$testName" ]]; then
               echo "Running test: $testName"
-              python testRunner_snitch.py -t Tests/$testName --simulator=banshee --cores=9 --toolchain_install_dir /app/install/riscv-llvm/
+              python testRunner_snitch.py -t Tests/$testName --simulator=${{ inputs.simulator }} --cores=${{ inputs.num-cores }} --toolchain_install_dir /app/install/riscv-llvm/
             fi
           done
         shell: bash
diff --git a/.github/workflows/TestRunnerTiledSnitch.yml → ...flows/TestRunnerTiledSnitchSequential.yml b/.github/workflows/TestRunnerTiledSnitch.yml → ...flows/TestRunnerTiledSnitchSequential.yml
@@ -1,11 +1,24 @@
-name: TestRunnerTiledSnitch
+name: TestRunnerTiledSnitchSequential
 
 on:
   workflow_call:
     inputs:
       tests-config:
         required: true
         type: string
+      num-cores:
+        required: false
+        default: 9
+        type: number
+      default-memory-level:
+        required: false
+        default: "L2"
+        type: string
+      simulator:
+        required: false
+        default: "banshee"
+        type: string
+
 
 jobs:
 
@@ -40,7 +53,7 @@ jobs:
             L1_values=$(echo "$test" | jq -r '.L1[]')
             for L1_value in $L1_values; do
               echo "Running test: $testName with L1: $L1_value"
-              python testRunner_tiled_snitch.py -t Tests/$testName --cores=9 --simulator=banshee --l1 $L1_value --defaultMemLevel=L2 --toolchain_install_dir /app/install/riscv-llvm/
+              python testRunner_tiled_snitch.py -t Tests/$testName --cores=${{ inputs.num-cores }} --simulator=${{ inputs.simulator }} --l1 $L1_value --defaultMemLevel=${{ inputs.default-memory-level }} --toolchain_install_dir /app/install/riscv-llvm/
             done
           done
         shell: bash