Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Several bug fixes and improvements #6

Merged
merged 6 commits into from
Oct 16, 2024
Merged

Several bug fixes and improvements #6

merged 6 commits into from
Oct 16, 2024

Conversation

gamzeisl
Copy link
Collaborator

This PR fixes several bugs and improves some features:

  1. Convert the signed interpretation of softmax to unsigned in PyITA.
  2. Extend simvector folder name with the selected activation.
  3. Correct the pipeline signals for the activation unit.
  4. Silence relu and gelu inputs when these activations are not selected.
  5. Add tests to ci for no stall case, which actually revealed the wrong pipeline signals in the activation unit.

@gamzeisl gamzeisl requested a review from Xeratec October 10, 2024 13:05
@gamzeisl gamzeisl marked this pull request as draft October 10, 2024 17:02
@gamzeisl
Copy link
Collaborator Author

gamzeisl commented Oct 10, 2024 •
edited
Loading

  • Run further tests before merging using tests

Xeratec
Xeratec approved these changes Oct 12, 2024
View reviewed changes
Copy link
Collaborator

@Xeratec Xeratec left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far, thanks for debugging 😊

@gamzeisl gamzeisl marked this pull request as ready for review October 16, 2024 08:39
@gamzeisl gamzeisl merged commit ebd365e into main Oct 16, 2024
6 checks passed
@gamzeisl gamzeisl deleted the bugfixes branch October 16, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xeratec Xeratec Xeratec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gamzeisl @Xeratec