Support for single attention layer #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xeratec
approved these changes
Oct 30, 2024
Comment on lines
+66
to
+69
| if (bias_dir_i) begin | ||
| bias_reshape = read_data >> read_cnt_q[3:0] * 24; | ||
| data_o.data = {N {bias_reshape[0]}}; | ||
| end |
There was a problem hiding this comment.
I believe this is related to
Transposition of biases for V generation is moved from ITA engine to HWPE side.
However, I do not see how this is now handled on the HWPE side. Can you give me a quick pointer?
There was a problem hiding this comment.
Here, we fetch one set of biases, find the required one with counter and replicate it N times. Previously, ITA was replicating them internally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new layer called
SingleAttentionthat only calculates QK and AV. Testbenches and ci tests are modified accordingly.Additionally:
buildpathfor simulations is fixed in the Makefile.