Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HW]: Add axi cut in the memory island domain to remove timing loops #50

Merged
merged 1 commit into from
Oct 22, 2024
Merged

[HW]: Add axi cut in the memory island domain to remove timing loops #50

merged 1 commit into from
Oct 22, 2024

Conversation

Lore0599
Copy link

@Lore0599 Lore0599 commented Oct 18, 2024 •
edited
Loading

Timing Loop Fix

This PR add an axi_cut module inside the memory_island_domain to cut the combinatorial path between the memory island response and request channels when passing through the axi_riscv_atomics_structs module.

@Lore0599 Lore0599 requested a review from Scheremo October 18, 2024 13:18
@FrancescoConti
Copy link
Member

Oops! 😄

Scheremo
Scheremo approved these changes Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@Scheremo Scheremo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Lore0599 Lore0599 merged commit a9435f5 into devel Oct 22, 2024
6 checks passed
@Lore0599 Lore0599 deleted the lleone/timingloops branch October 22, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Scheremo Scheremo Scheremo approved these changes

@FrancescoConti FrancescoConti Awaiting requested review from FrancescoConti

@adimauro-iis adimauro-iis Awaiting requested review from adimauro-iis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lore0599 @FrancescoConti @Scheremo