Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PUSCH receiver kernels #108

Open
wants to merge 38 commits into
base: main
Choose a base branch
from
Open

PUSCH receiver kernels #108

wants to merge 38 commits into from

Conversation

mbertuletti
Copy link
Collaborator

Changelog

Added

  • FFT f16
  • Complex matmul f16, complex matmul fixed-point 16
  • Cholesky decomposition f16, Cholesky decomposition fixed-point 16
  • Linear system solution f16, Linear system solution fixed-point 16
  • MMSE application f16, MMSE application fixed-point 16
  • OFDM application f16

Checklist

  • Automated tests pass
  • Changelog updated
  • Code style guideline is observed

Please check our contributing guidelines before opening a Pull Request.

@mbertuletti mbertuletti force-pushed the mbertuletti/mimo_receiver branch 6 times, most recently from 3fae5dd to d7c809d Compare April 25, 2024 13:55
@mbertuletti mbertuletti force-pushed the mbertuletti/mimo_receiver branch from d7c809d to b9ff155 Compare July 5, 2024 14:58
@mbertuletti mbertuletti force-pushed the mbertuletti/mimo_receiver branch 5 times, most recently from 21bbf18 to 4ba934c Compare August 27, 2024 14:51
@mbertuletti mbertuletti force-pushed the mbertuletti/mimo_receiver branch 6 times, most recently from 26dacc3 to bf0e68d Compare September 5, 2024 12:22
@mbertuletti mbertuletti force-pushed the mbertuletti/mimo_receiver branch 4 times, most recently from d1605f1 to a1bc514 Compare September 13, 2024 06:59
@mbertuletti mbertuletti force-pushed the mbertuletti/mimo_receiver branch 2 times, most recently from c7c4ea6 to 8d5ad46 Compare October 16, 2024 09:20
@mbertuletti mbertuletti force-pushed the mbertuletti/mimo_receiver branch 3 times, most recently from e11e157 to 0f9df05 Compare October 28, 2024 13:19
@mbertuletti
[software] Add mimo_mmse_q16 kernels (fixed-point precision)
b7a0c84
@mbertuletti
[software] Fix cfft_radix4_f16 butterfly operations
a170b74
@mbertuletti
[software] Adapt data generation to folder structure in #PR96
380729c
@mbertuletti
[software] Add complex instructions to cmatmul_f16
bb58026 
[software] Load vector type in cmatmul_f16
@mbertuletti
[software] Handle multiple beamgroups in mimo_mmse_f16
962c313
@mbertuletti
[software] Add and compile mimo_mmse_f16 with soft-divsqrt
6ec634e
@mbertuletti
[software] Add cmatmul_q16 (complex fixed-point matrix-multiplication)
d8d29b6
@mbertuletti
[software] Modify channel estimation with multiplication by pilots
7c6c1b6
@mbertuletti
[software] Fix data loading in cfft_radix4_f16
ac589b2
@mbertuletti
[software] Adapt to new folder structure in #PR96
8bed4ad
@mbertuletti
[software] Remove load of che inputs from inner loop
0e6b37c
@mbertuletti
[software] Add shuffle instruction in cfft_radix4_f16
0e3894f
@mbertuletti
[software] Clean-up complex matmuls
f0270f8
@mbertuletti mbertuletti force-pushed the mbertuletti/mimo_receiver branch from 5010e69 to 916a29a Compare December 6, 2024 10:57
yichao-zh
yichao-zh reviewed Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@yichao-zh yichao-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Marco, this is very good merge request. I reviewed files and there almost nothing really need to futher changes, only very few suggestions. And also, something maybe we can do together with this merge:

  1. For the MatMul kernels. I saw the "conflict optimization" kernel (which I did during the PUSCH DATE) was included in matmul_f32, but it is not included the integar kernels, could you also help to copy-paste into the integar kernel file?
  2. Dont forget to update the "change log" file.

Thats all! Thanks!

software/apps/baremetal/axpy_f16/main.c
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is better to add a "#define local_parallel" instead of commenting the others out.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, thanks.

software/apps/baremetal/axpy_f32/main.c
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same at this kernel, if we keep all of the kernels in this "main.c", we should add #define. Otherwise, we only leave one kernel instead of commenting others out. What do you think?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@mbertuletti mbertuletti force-pushed the mbertuletti/mimo_receiver branch 4 times, most recently from 82c5e0b to c2db140 Compare December 10, 2024 14:01
@mbertuletti mbertuletti force-pushed the mbertuletti/mimo_receiver branch from c2db140 to 0f1de6f Compare December 10, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yichao-zh yichao-zh yichao-zh left review comments

@SamuelRiedel SamuelRiedel Awaiting requested review from SamuelRiedel SamuelRiedel is a code owner

@sermazz sermazz Awaiting requested review from sermazz sermazz is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbertuletti @yichao-zh