Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DMA #87

Merged
merged 3 commits into from
Nov 10, 2023
Merged

Fix DMA #87

merged 3 commits into from
Nov 10, 2023

Conversation

SamuelRiedel
Copy link
Member

@SamuelRiedel SamuelRiedel commented Sep 22, 2023

Fix two small bugs in the DMA's midend and insert pipeline registers

Changelog

Fixed

  • Fix a bug in the DMA's distributed midend

Checklist

  • Automated tests pass
  • Changelog updated
  • Code style guideline is observed

When a DMA request finishes in the same cycle as we cut one off we have
to wait a cycle. This will need proper handshaking in the future
Copy link
Collaborator

@sermazz sermazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@SamuelRiedel SamuelRiedel merged commit 5cba362 into main Nov 10, 2023
62 checks passed
@SamuelRiedel SamuelRiedel deleted the dma-fix branch November 10, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants