Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance metrics #89

Merged
merged 3 commits into from
Oct 12, 2023
Merged

Performance metrics #89

merged 3 commits into from
Oct 12, 2023

Conversation

SamuelRiedel
Copy link
Member

@SamuelRiedel SamuelRiedel commented Oct 9, 2023

Disable the simulation-only debugging CSRs (tracing, stack-overflow warning) and parameterize the stall counter performance registers. Also, add some waves to easier debug and benchmark on MemPool by visualizing performance in real-time. I added some default ones and more additional ones are welcome.

waves

Changelog

Changed

  • Parametrize the performance counters

Fixed

  • Properly disable the debugging CSRs in ASIC implementations

Checklist

  • Automated tests pass
  • Changelog updated
  • Code style guideline is observed

Copy link
Collaborator

@mbertuletti mbertuletti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good to me. With little effort we can adapt it to the TeraPool and the MinPool configs.

hardware/scripts/questa/wave.tcl Show resolved Hide resolved
hardware/tb/mempool_tb.sv Show resolved Hide resolved
Copy link
Collaborator

@sermazz sermazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, after we resolve Marco's comment!

Copy link
Collaborator

@mbertuletti mbertuletti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are okay, when the CI passes we can merge.

@SamuelRiedel SamuelRiedel merged commit 289be33 into main Oct 12, 2023
62 checks passed
@SamuelRiedel SamuelRiedel deleted the performance-metrics branch October 12, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants