Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dismiss obsolete icache code. #42

Merged
merged 2 commits into from
Feb 8, 2024
Merged

Dismiss obsolete icache code. #42

merged 2 commits into from
Feb 8, 2024

Conversation

yvantor
Copy link
Contributor

@yvantor yvantor commented Feb 8, 2024

SP and MP iCache have been completely replaced by the hierarchical. This PR is intended to cleanup the top level of PULP cluster to simplify the code and make it more readable.

@yvantor yvantor requested review from luca-valente and OttG February 8, 2024 10:03
@FrancescoConti
Copy link
Member

Yeah, LGTM, it makes no sense to keep those `ifdef's around.
If we ever need, we'll reintegrate the SP and MP icaches more cleanly.

@OttG
Copy link
Collaborator

OttG commented Feb 8, 2024

LGTM too, merging

@OttG OttG merged commit 0c8c3bf into master Feb 8, 2024
5 checks passed
@yvantor yvantor deleted the yt/cleanup-1 branch February 8, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants