Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added softmax accelerator #66

Closed
wants to merge 6 commits into from
Closed

Added softmax accelerator #66

wants to merge 6 commits into from

Conversation

belanoa
Copy link

@belanoa belanoa commented May 7, 2024

No description provided.

yvantor
yvantor reviewed May 7, 2024
View reviewed changes
Copy link
Contributor

@yvantor yvantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no regression test added for the accelerator. I think this is required before merging (once we have it, we can also add it to the CI)

Bender.yml Outdated Show resolved Hide resolved
FrancescoConti
FrancescoConti requested changes May 7, 2024
View reviewed changes
Copy link
Member

@FrancescoConti FrancescoConti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change I request is only the open sourcing of course ;)

Bender.yml Outdated Show resolved Hide resolved
@belanoa belanoa requested a review from FrancescoConti May 8, 2024 08:39
@belanoa belanoa force-pushed the ab/softmax-integration branch from 6603366 to 9ef7728 Compare May 31, 2024 14:09
@belanoa belanoa closed this May 31, 2024
@yvantor
Copy link
Contributor

yvantor commented May 31, 2024

Closing as tackeld in #71.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yvantor yvantor yvantor left review comments

@FrancescoConti FrancescoConti Awaiting requested review from FrancescoConti

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@belanoa @yvantor @FrancescoConti