Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to pu/pu 3.143.0 and define the Handshake provider methods #2731

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

mikhailshilkov
Copy link
Member

@mikhailshilkov mikhailshilkov commented Dec 12, 2024

Updates package dependencies on pulumi/pulumi to 3.143.0. 3.143.0 introduced Handshake in the provider protocol, so we need to stub it out to prevent the compilation errors. For now, Handshake always returns a not implemented error.

Supersedes #2730

@mikhailshilkov mikhailshilkov marked this pull request as draft December 12, 2024 10:56
@mikhailshilkov mikhailshilkov force-pushed the mikhailshilkov/pu-3-143-handshake branch from 76515bf to 7a1900e Compare December 12, 2024 10:59
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 69.57%. Comparing base (6af66d0) to head (7a1900e).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/pf/internal/plugin/provider_context.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2731      +/-   ##
==========================================
- Coverage   69.57%   69.57%   -0.01%     
==========================================
  Files         301      301              
  Lines       38654    38658       +4     
==========================================
+ Hits        26893    26895       +2     
- Misses      10242    10244       +2     
  Partials     1519     1519              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikhailshilkov mikhailshilkov marked this pull request as ready for review December 12, 2024 12:15
Copy link
Contributor

@VenelinMartinov VenelinMartinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikhailshilkov mikhailshilkov merged commit 5a5b8b6 into master Dec 12, 2024
17 checks passed
@mikhailshilkov mikhailshilkov deleted the mikhailshilkov/pu-3-143-handshake branch December 12, 2024 12:21
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v3.98.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants