Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop-rspec requirement from ~> 1.40 to ~> 2.28 #111

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 1, 2024

Updates the requirements on rubocop-rspec to permit the latest version.

Release notes

Sourced from rubocop-rspec's releases.

RuboCop RSpec v2.28.0

  • Extract RSpec Rails cops to a separate repository, rubocop-rspec_rails. The rubocop-rspec_rails repository is a dependency of rubocop-rspec and the cops related to rspec-rails are aliased (RSpec/Rails/Foo == RSpecRails/Foo) until v3.0 is released, so the change will be invisible to users until then. (@​ydah)
Changelog

Sourced from rubocop-rspec's changelog.

2.28.0 (2024-03-30)

  • Extract RSpec Rails cops to a separate repository, rubocop-rspec_rails. The rubocop-rspec_rails repository is a dependency of rubocop-rspec and the cops related to rspec-rails are aliased (RSpec/Rails/Foo == RSpecRails/Foo) until v3.0 is released, so the change will be invisible to users until then. ([@​ydah])

2.27.1 (2024-03-03)

  • Fix a false positive for RSpec/RepeatedSubjectCall when subject.method_call. ([@​ydah])
  • Add configuration option OnlyStaticConstants to RSpec/DescribedClass. ([@​ydah])

2.27.0 (2024-03-01)

  • Add new RSpec/IsExpectedSpecify cop. ([@​ydah])
  • Add new RSpec/RepeatedSubjectCall cop. ([@​drcapulet])
  • Add support for assert_true, assert_false, assert_not_equal, assert_not_nil, *_empty, *_predicate, *_kind_of, *_in_delta, *_match, *_instance_of and *_includes assertions in RSpec/Rails/MinitestAssertions. ([@​ydah], [@​G-Rath])
  • Support asserts with messages in Rspec/BeEmpty. ([@​G-Rath])
  • Fix a false positive for RSpec/ExpectActual when used with rspec-rails routing matchers. ([@​naveg])
  • Add configuration option ResponseMethods to RSpec/Rails/HaveHttpStatus. ([@​ydah])
  • Fix a false negative for RSpec/DescribedClass when class with constant. ([@​ydah])
  • Fix a false positive for RSpec/ExampleWithoutDescription when specify with multi-line block and missing description. ([@​ydah])
  • Fix an incorrect autocorrect for RSpec/ChangeByZero when compound expectations with line break before .by(0). ([@​ydah])

2.26.1 (2024-01-05)

  • Fix an error for RSpec/SharedExamples when using examples without argument. ([@​ydah])

2.26.0 (2024-01-04)

  • Add new RSpec/RedundantPredicateMatcher cop. ([@​ydah])
  • Add new RSpec/RemoveConst cop. ([@​swelther])
  • Add support for correcting "it will" (future tense) for RSpec/ExampleWording. ([@​jdufresne])
  • Add support for symbol style for RSpec/SharedExamples. ([@​jessieay])
  • Ensure PendingWithoutReason can detect violations inside shared groups. ([@​robinaugh])

2.25.0 (2023-10-27)

  • Add support single quoted string and percent string and heredoc for RSpec/Rails/HttpStatus. ([@​ydah])
  • Change to be inline disable for RSpec/SpecFilePathFormat like RSpec/FilePath. ([@​ydah])
  • Fix a false positive for RSpec/MetadataStyle with example groups having multiple string arguments. ([@​franzliedke])

2.24.1 (2023-09-23)

  • Fix an error when using RSpec/FilePath and revert to enabled by default. If you have already moved to RSpec/SpecFilePathSuffix and RSpec/SpecFilePathFormat, disable RSpec/FilePath explicitly as Enabled: false. The RSpec/FilePath before migration and the RSpec/SpecFilePathSuffix and RSpec/SpecFilePathFormat as the target are available respectively. ([@​ydah])

2.24.0 (2023-09-08)

  • Split RSpec/FilePath into RSpec/SpecFilePathSuffix and RSpec/SpecFilePathFormat. RSpec/FilePath cop is disabled by default and the two new cops are pending and need to be enabled explicitly. ([@​ydah])
  • Add new RSpec/Eq cop. ([@​ydah])
  • Add RSpec/MetadataStyle and RSpec/EmptyMetadata cops. ([@​r7kamura])
  • Add support RSpec/Rails/HttpStatus when have_http_status with string argument. ([@​ydah])
  • Fix an infinite loop error when RSpec/ExcessiveDocstringSpacing finds a description with non-ASCII leading/trailing whitespace. ([@​bcgraham])

... (truncated)

Commits
  • e6b53cb Merge pull request #1844 from rubocop/release
  • 05b93ad Bump version to v2.28.0
  • 85e6c8f Merge pull request #1842 from rubocop/add-test2
  • f6314a7 Merge pull request #1830 from rubocop/extract-rspec-rails
  • ae19ff1 Extract RSpec Rails cops
  • bf3f3e5 Add test to ensure unsafe cops are properly configured
  • 281a65b Merge pull request #1841 from rubocop/add-test
  • 077100f Add test case for detect redundant SafeAutoCorrect: false config
  • ecd945f Merge pull request #1839 from rubocop/use-registers-no-offense
  • 36d24d8 Use 'registers no offense' instead of 'register no offense'
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Updates the requirements on [rubocop-rspec](https://github.com/rubocop/rubocop-rspec) to permit the latest version.
- [Release notes](https://github.com/rubocop/rubocop-rspec/releases)
- [Changelog](https://github.com/rubocop/rubocop-rspec/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop-rspec@v1.40.0...v2.28.0)

---
updated-dependencies:
- dependency-name: rubocop-rspec
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from a team as a code owner April 1, 2024 13:50
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Apr 1, 2024
@dependabot dependabot bot requested a review from a team as a code owner April 1, 2024 13:50
@puppetlabs-jenkins
Copy link
Contributor

Can one of the admins verify this patch?

Copy link
Contributor Author

dependabot bot commented on behalf of github Apr 5, 2024

Superseded by #112.

@dependabot dependabot bot closed this Apr 5, 2024
@dependabot dependabot bot deleted the dependabot/bundler/rubocop-rspec-tw-2.28 branch April 5, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant