Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Ensure bash shell executions close file descriptors
Currently Bolt::Shell::Bash will leaves open file descriptors at the conclusion of execute(). The file descriptions do fall out of scope at the conclusion of the execute() method and the Ruby GC eventually closes them. However, on a very busy Bolt invocation with lots of short-lived Tasks or a number of Tasks running in parallel (e.g. via background()) the number of open FDs before garbage collection can get moderately high, hitting problems on systems with low file descriptor limits. !bug * **Explicitly close Bolt::Shell::Bash file descriptors** Ensure file descriptors in Bolt::Shell::Bash are explicitly closed, helping to alleviate the chance of hitting file descriptor limits on systems with low defaults (e.g. Mac OS).
- Loading branch information