Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GH-3217) Only log compiled catalogs at trace level #3222

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

donoghuc
Copy link
Contributor

Previously compiled catalogs would be logged per target at INFO level. This clogs up logs and can expose Sensitive data in catalogs. This commit moves logging of compiled catalogs to the TRACE log level only.

!bug

  • Only log compiled catalogs at trace level (#3217)

    Previously compiled catalogs would be logged per target at INFO level. This clogs up logs and can expose Sensitive data in catalogs. This commit moves logging of compiled catalogs to the TRACE log level only.

Previously compiled catalogs would be logged per target at INFO level. This clogs up logs and can expose Sensitive data in catalogs. This commit moves logging of compiled catalogs to the TRACE log level only.

!bug

* **Only log compiled catalogs at trace level**
  ([puppetlabs#3217](puppetlabs#3217))

  Previously compiled catalogs would be logged per target at INFO level. This clogs up
  logs and can expose Sensitive data in catalogs. This commit moves logging of
  compiled catalogs to the TRACE log level only.
Copy link
Contributor

@jpartlow jpartlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Works in my local testing. Compiled catalog is no longer logged by default, so the secrets no longer show; but you can get the catalog info back with --log-level trace.

@donoghuc donoghuc merged commit 1a1166e into puppetlabs:main Aug 11, 2023
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants