Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add shell-command and tty support to the LXD transport #3262

Merged
merged 1 commit into from
May 7, 2024

Conversation

h0tw1r3
Copy link
Contributor

@h0tw1r3 h0tw1r3 commented Jan 29, 2024

!feature

  • add shell-command and tty support to the LXD transport (#3262)

Previously the LXD transport would always execute commands on the target with sh -c. The shell-command and tty options are added to provide a more consistent experience between the docker, podman and lxd transports.

!feature

* **add shell-command and tty support to the LXD transport** ([puppetlabs#3262](puppetlabs#3262))

Previously the LXD transport would always execute commands on the
target with `sh -c`. The shell-command and tty options are added
to provide a more consistent experience between the docker, podman
and lxd transports.
@h0tw1r3 h0tw1r3 added the Feature New features and improvements. label Jan 29, 2024
@h0tw1r3 h0tw1r3 requested a review from a team as a code owner January 29, 2024 02:28
@h0tw1r3
Copy link
Contributor Author

h0tw1r3 commented Jan 29, 2024

End goal is to implement litmus testing with the lxd (or incus) transport.

This is a blocker because the static shell command sh -c will not allow the litmus:install_agent rake task to complete. Docker and podman work with litmus because it's able to set shell-command to sh -lc.

h0tw1r3 added a commit to h0tw1r3/bolt that referenced this pull request Jan 29, 2024
!feature

* **add shell-command and tty support to the LXD transport** ([puppetlabs#3262](puppetlabs#3262))

Previously the LXD transport would always execute commands on the
target with `sh -c`. The shell-command and tty options are added
to provide a more consistent experience between the docker, podman
and lxd transports.
@h0tw1r3
Copy link
Contributor Author

h0tw1r3 commented Feb 2, 2024

reminder to self, there are no tests for lxd as it's considered experimental.

h0tw1r3 added a commit to h0tw1r3/bolt that referenced this pull request Feb 9, 2024
!feature

* **add shell-command and tty support to the LXD transport** ([puppetlabs#3262](puppetlabs#3262))

Previously the LXD transport would always execute commands on the
target with `sh -c`. The shell-command and tty options are added
to provide a more consistent experience between the docker, podman
and lxd transports.
h0tw1r3 added a commit to h0tw1r3/bolt that referenced this pull request Feb 9, 2024
!feature

* **add shell-command and tty support to the LXD transport** ([puppetlabs#3262](puppetlabs#3262))

Previously the LXD transport would always execute commands on the
target with `sh -c`. The shell-command and tty options are added
to provide a more consistent experience between the docker, podman
and lxd transports.
h0tw1r3 added a commit to h0tw1r3/bolt that referenced this pull request Feb 9, 2024
!feature

* **add shell-command and tty support to the LXD transport** ([puppetlabs#3262](puppetlabs#3262))

Previously the LXD transport would always execute commands on the
target with `sh -c`. The shell-command and tty options are added
to provide a more consistent experience between the docker, podman
and lxd transports.
h0tw1r3 added a commit to h0tw1r3/bolt that referenced this pull request Feb 10, 2024
!feature

* **add shell-command and tty support to the LXD transport** ([puppetlabs#3262](puppetlabs#3262))

Previously the LXD transport would always execute commands on the
target with `sh -c`. The shell-command and tty options are added
to provide a more consistent experience between the docker, podman
and lxd transports.
h0tw1r3 added a commit to h0tw1r3/bolt that referenced this pull request Feb 13, 2024
!feature

* **add shell-command and tty support to the LXD transport** ([puppetlabs#3262](puppetlabs#3262))

Previously the LXD transport would always execute commands on the
target with `sh -c`. The shell-command and tty options are added
to provide a more consistent experience between the docker, podman
and lxd transports.
h0tw1r3 added a commit to h0tw1r3/bolt that referenced this pull request Mar 15, 2024
!feature

* **add shell-command and tty support to the LXD transport** ([puppetlabs#3262](puppetlabs#3262))

Previously the LXD transport would always execute commands on the
target with `sh -c`. The shell-command and tty options are added
to provide a more consistent experience between the docker, podman
and lxd transports.
h0tw1r3 added a commit to h0tw1r3/bolt that referenced this pull request Apr 17, 2024
!feature

* **add shell-command and tty support to the LXD transport** ([puppetlabs#3262](puppetlabs#3262))

Previously the LXD transport would always execute commands on the
target with `sh -c`. The shell-command and tty options are added
to provide a more consistent experience between the docker, podman
and lxd transports.
@h0tw1r3 h0tw1r3 closed this May 6, 2024
@h0tw1r3 h0tw1r3 reopened this May 6, 2024
@donoghuc donoghuc self-assigned this May 7, 2024
@donoghuc donoghuc merged commit a069e60 into puppetlabs:main May 7, 2024
69 of 89 checks passed
@h0tw1r3 h0tw1r3 deleted the lxd-transport-options branch May 17, 2024 16:42
@h0tw1r3 h0tw1r3 restored the lxd-transport-options branch May 24, 2024 20:27
@h0tw1r3 h0tw1r3 deleted the lxd-transport-options branch May 24, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New features and improvements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants