(maint) Turn off analytics submissions #3294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collecting analytics is now turned off by default. !removal * **Stop collecting bolt analytics** ([puppetlabs#3293](puppetlabs#3293)) Bolt no longer collects analytics by default.
donoghuc
force-pushed
the
disable-analytics
branch
from
0bd6351
to
b2018df
Compare
Docker-compose does not appear to be installed on ubuntu-latest runners. Ensure it is installed before bringing up test cluster.
donoghuc
force-pushed
the
disable-analytics
branch
2 times, most recently
from
65c4eb2
to
cd44c5f
Compare
This is the last release that passes for building bolt docs. Pin to that version while we evaluate how to remain compatible with latest.
donoghuc
force-pushed
the
disable-analytics
branch
from
cd44c5f
to
19ee965
Compare
We attempt to compute Execution Policy in order to provide a nice error message for some cases. We are seeing failures in some cases to compute this value. In the case the execution policy cannot be determined we still want to be able to attempt to run the action. This commit handles errors when execution policy cannot be determined.
donoghuc
force-pushed
the
disable-analytics
branch
from
9634fdd
to
fbb2c52
Compare
donoghuc
commented
Apr 3, 2024
| @@ -55,21 +55,25 @@ def run_script(arguments, script_path) | |||
| } | |||
| #{build_arg_list} | |||
|
|
|||
| switch -regex ( Get-ExecutionPolicy ) | |||
| try | |||
There was a problem hiding this comment.
@mcdonaldseanp I think the path is messed up for module loading in our test runners:
+"merged_output" => "Get-ExecutionPolicy : The 'Get-ExecutionPolicy' command was found in the module 'Microsoft.PowerShell.Security', but \r\nthe module could not be loaded. For more information, run 'Import-Module Microsoft.PowerShell.Security'.\r\nAt line:10 char:17\r\n+ switch -regex ( Get-ExecutionPolicy )\r\n+ ~~~~~~~~~~~~~~~~~~~\r\n + CategoryInfo : ObjectNotFound: (Get-ExecutionPolicy:String) [], CommandNotFoundException\r\n + FullyQualifiedErrorId : CouldNotAutoloadMatchingModule\r\n \r\nparam\n",
I think that the intent of this was simply to provide a helpful error message and that we should not error if we cant load that module. In practice i doubt this comes up much because task running all works due to other powershell setup we do.
Do you think a catch here is reasonable, should it be more specific on objects it catches?
There was a problem hiding this comment.
#2659 for reference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collecting analytics is now turned off by default.
!removal
Stop collecting bolt analytics (#3293)
Bolt no longer collects analytics by default.