Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(CONT-1119) Add puppet-strings #522

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Conversation

chelnak
Copy link
Contributor

@chelnak chelnak commented Jun 20, 2023

Summary

This PR adds puppet-strings to the default template Gemfile.

Additional Context

Requires the following PR to be merged: puppetlabs/bolt#3216

Related Issues (if any)

PDK is unable to pull in newer versions of puppet-strings because of a dependency in bolt. We should also reference puppet-strings as a first party gem in module Gemfiles.

@chelnak chelnak requested a review from a team as a code owner June 20, 2023 13:54
@chelnak chelnak self-assigned this Jun 20, 2023
Copy link
Member

@david22swan david22swan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@david22swan david22swan merged commit aaff15c into main Aug 2, 2023
2 checks passed
@david22swan david22swan deleted the CONT-1119-add_puppet_strings branch August 2, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants