Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds support for having executable templates as described in #1224.
Additional Context
This PR makes use of a new
manage_execute_permissions
boolean config setting, which can be set on an individual template or enabled globally in thecommon
config key. The existing code relied on a:global
config setting:pdk/lib/pdk/template/renderer/v1/legacy_template_dir.rb
Line 59 in 4e46ce2
But as far as I can tell that key is no longer valid as neither the
Symbol
class nor the:global
symbol are allowed during YAML parsing:pdk/lib/pdk/template/renderer/v1/legacy_template_dir.rb
Line 94 in 4e46ce2
I noticed the current config_defaults file contains a
common
key, so I thought we could reuse that here.No spec or acceptance tests have been added and no documentation has been updated because I wanted to wait for consensus on this approach before spending time on testing or documentation.
Related Issues (if any)
#1224
Checklist