Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bolt task for provision service #131

Merged
merged 10 commits into from
Oct 28, 2020
Merged

Bolt task for provision service #131

merged 10 commits into from
Oct 28, 2020

Conversation

carabasdaniel
Copy link
Contributor

@carabasdaniel carabasdaniel commented Oct 23, 2020 •
edited by DavidS
Loading

Closes: #130, #129

@carabasdaniel carabasdaniel marked this pull request as ready for review October 26, 2020 10:26
@carabasdaniel carabasdaniel requested a review from a team as a code owner October 26, 2020 10:26
DavidS
DavidS reviewed Oct 27, 2020
View reviewed changes
Copy link
Contributor

@DavidS DavidS left a comment •
edited by carabasdaniel
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • handle smol improvements to the code from review comments
  • add some docs on how to use this task, at least an example of what to put into provision.yaml
  • move the closes: #... into the description of the PR to trigger issue linking

tasks/provision_service.rb Outdated Show resolved Hide resolved
tasks/provision_service.rb Outdated Show resolved Hide resolved
carabasdaniel and others added 4 commits October 27, 2020 13:37
@carabasdaniel @DavidS
Show unknown verb in the error
440f154 
Co-authored-by: David Schmitt <david.schmitt@puppet.com>
@carabasdaniel @DavidS
Use default for GITHUB_URL
e6258ba 
Co-authored-by: David Schmitt <david.schmitt@puppet.com>
Update README.md
ea53d43
Fix typo in GITHUB_RUN_ID ENV usage
a25d694
@DavidS DavidS mentioned this pull request Oct 28, 2020
Merged
4 tasks
@DavidS DavidS linked an issue Oct 28, 2020 that may be closed by this pull request
Create Bolt task to be able to interact with the facade of the provisioning service #129
Closed
@DavidS DavidS merged commit ee4b7fc into puppetlabs:main Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidS DavidS DavidS approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Bolt task to be able to interact with the facade of the provisioning service
3 participants
@carabasdaniel @DavidS @Ramesh7