Docker run opts #151
Merged
Docker run opts #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This functionality will be added to the inventory vars as option `docker_run_opts`.
|
Happy new year everybody. Is there an ATA when there is time to look at this PR? |
Sharpie
added a commit
to Sharpie/puppet-dev-images
that referenced
this pull request
Jul 30, 2021
The `append_cli` parameter was removed from the `provision::docker_exp` task by puppetlabs/provision#151. This commit moves the image testing workflows to use the `docker_run_opts` replacement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the
docker_expprovisioner work in the same way as thedockerprovisioned. See also puppetlabs/puppet_litmus#358. To make it more consistent also remove the old way of doing things from thedocker_expprovider.This PR will also be accompanied by a PR on puppetlabs/puppet_litmus.