(maint) Add a spec case for the provision::abs task #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have some rubocop issues to sort out. Ok, those are fixed. |
jpartlow
force-pushed
the
maint-add-abs-task-spec
branch
from
e4ee99b
to
03cedb8
Compare
MikaelSmith
reviewed
Dec 15, 2021
jpartlow
force-pushed
the
maint-add-abs-task-spec
branch
from
03cedb8
to
4a9ad02
Compare
MikaelSmith
previously approved these changes
Dec 16, 2021
Codecov Report
@@ Coverage Diff @@
## main #186 +/- ##
=======================================
Coverage ? 76.97%
=======================================
Files ? 2
Lines ? 139
Branches ? 0
=======================================
Hits ? 107
Misses ? 32
Partials ? 0 Continue to review full report at Codecov.
|
MikaelSmith
previously approved these changes
Jan 26, 2022
chelnak
previously approved these changes
Feb 11, 2022
The abs.rb is refactored into a class that is executed only if the task file is the executing program. This allows the spec to load the task and manipulate the class while mocking externals. The webmock gem is used to provide HTTP::Net mocking. The spec is not exhaustive, but hopefully covers enough to validate that the refactor didn't break the task, and that the bug I added in puppetlabs#182 is patched. It could be expanded, and could serve as a template for adding specs for other tasks in the module. It does look to expose an edge case bug of calling the provision task with an inventory directory specified that contains a pre-existing inventory file.
jpartlow
force-pushed
the
maint-add-abs-task-spec
branch
from
24f910e
to
cd72bb6
Compare
chelnak
approved these changes
Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The abs.rb is refactored into a class that is executed only if the task
file is the executing program. This allows the spec to load the task and
manipulate the class while mocking externals. The webmock gem is used to
provide HTTP::Net mocking.
The spec is not exhaustive, but hopefully covers enough to validate that
the refactor didn't break the task, and that the bug I added in #182 is
patched.
It could be expanded, and could serve as a template for adding specs
for other tasks in the module.
It does look to expose an edge case bug of calling the provision task
with an inventory directory specified that contains a pre-existing
inventory file.