(CONT-1241) - Retrying when response body is nil or empty but response code is 200 #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ramesh7
force-pushed
the
CONT-1241-retry
branch
6 times, most recently
from
bc4a3e9
to
2cd719c
Compare
Ramesh7
changed the title
Ramesh7
changed the title
Ramesh7
changed the title
Ramesh7
changed the title
jordanbreen28
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We have seen multiple failures where the response is not expected but the response code is 200, so while parsing it fails which lead to pipeline failure.
So added retry when response is empty or while parsing it fails.
Eg : https://github.com/puppetlabs/puppetlabs-lvm/actions/runs/5639289396/job/15274332392
Additional Context
Related Issues (if any)
Checklist