(CAT-1211) - Fixing regression of CAT-1241 #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ramesh7
force-pushed
the
CAT-1211-bolt-command-failure
branch
2 times, most recently
from
9af42ba
to
5799fe4
Compare
|
Just regarding the above comment, it's worth noting that these changes will not need released before they will be consumed by our other modules. In the fixtures.yml, for the provision module we reference the git main branch, not a release tag, see here. |
Ramesh7
force-pushed
the
CAT-1211-bolt-command-failure
branch
from
5799fe4
to
b9f9c26
Compare
Thanks for reminding, I missed it to use .fixture.yml. |
jordanbreen28
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While implementing retry for nil class error the inventory param got initilized with nil which lead to error while provision via Bolt but works fine with litmus.
Additional Context
The change has been validated here
The provision step is completed without any issues.
Related Issues (if any)
Checklist