Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flexible Linux box support for Vagrant #242

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

seanmil
Copy link
Contributor

@seanmil seanmil commented Sep 29, 2023

Determining the SSH service restart command needed based on the Vagrant box name containing one of the expected sequences is problematic. With this change the required service restart command should be automatically determined for at least all vaguely recent Debian, Ubuntu, EL, or Suse systems, regardless of box name.

@seanmil seanmil requested a review from a team as a code owner September 29, 2023 17:28
@seanmil seanmil force-pushed the vagrant_detect_service_restart branch from 1172ab7 to c9fd9de Compare September 29, 2023 19:43
Determining the SSH service restart command needed based on
the Vagrant box name containing one of the expected sequences
is problematic. With this change the required service restart
command should be automatically determined for at least all
vaguely recent Debian, Ubuntu, EL, or Suse systems, regardless
of box name.
@seanmil seanmil force-pushed the vagrant_detect_service_restart branch from c9fd9de to 07f15ef Compare October 16, 2023 17:57
Copy link
Member

@david22swan david22swan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change look's good to me

@david22swan david22swan merged commit 764dcdf into puppetlabs:main Oct 17, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants