Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tear_down from puppet_litmus #268

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

h0tw1r3
Copy link
Contributor

@h0tw1r3 h0tw1r3 commented Jul 9, 2024

Summary

puppet_litmus gem is passing the target uri as the node_name param, which causes an InventoryHelper.lookup exception.

Additional Context

  • Easily reproducible by following the standard litmus testing workflow with the docker, docker_exp, or vagrant backends. Provisioning and testing works fine, but litmus:tear_down throws an exception.
  • By using the unnamed param to lookup instead of name, lookup will automatically search for a matching target uri, or name value.

Checklist

  • 🟢 Spec tests.
  • Manually verified.

puppet_litmus gem is passing the target uri as the node_name param, which
causes an InventoryHelper.lookup exception.
@h0tw1r3 h0tw1r3 requested a review from a team as a code owner July 9, 2024 09:24
@h0tw1r3
Copy link
Contributor Author

h0tw1r3 commented Jul 9, 2024

@jordanbreen28 hotfix to #260

Copy link
Contributor

@jordanbreen28 jordanbreen28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@h0tw1r3 you're on the ball 🚀

@jordanbreen28 jordanbreen28 merged commit ba875ea into puppetlabs:main Jul 9, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants