Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(CAT-1958) - Fix 404 on teardown of abs node #270

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

jordanbreen28
Copy link
Contributor

@jordanbreen28 jordanbreen28 commented Jul 11, 2024

Summary

This alters the request body payload object to correctly reference the node job id which is required for tear_down of an abs node.

Additional Context

Before:

bundle exec rake 'litmus:tear_down'                                                                                  
HEAD is now at c511041 Merge pull request #647 from puppetlabs/release-prep
rake aborted!
tear_down of our_abs_node.net failed.
Results:
  localhost: {"_error"=>{"kind"=>"provision/abs_failure", "msg"=>"Error: #<Net::HTTPNotFound:0x000000010c2d98a0>: Not Found", "details"=>{}}}}
/Users/jordan.breen/Desktop/repos/modules/puppetlabs-motd/.bundle/gems/ruby/3.2.0/gems/puppet_litmus-1.4.0/lib/puppet_litmus/rake_helper.rb:335:in `raise_bolt_errors'
/Users/jordan.breen/Desktop/repos/modules/puppetlabs-motd/.bundle/gems/ruby/3.2.0/gems/puppet_litmus-1.4.0/lib/puppet_litmus/rake_helper.rb:129:in `tear_down'
/Users/jordan.breen/Desktop/repos/modules/puppetlabs-motd/.bundle/gems/ruby/3.2.0/gems/puppet_litmus-1.4.0/lib/puppet_litmus/rake_helper.rb:104:in `block in tear_down_nodes'
/Users/jordan.breen/Desktop/repos/modules/puppetlabs-motd/.bundle/gems/ruby/3.2.0/gems/puppet_litmus-1.4.0/lib/puppet_litmus/rake_helper.rb:100:in `each'
/Users/jordan.breen/Desktop/repos/modules/puppetlabs-motd/.bundle/gems/ruby/3.2.0/gems/puppet_litmus-1.4.0/lib/puppet_litmus/rake_helper.rb:100:in `tear_down_nodes'
/Users/jordan.breen/Desktop/repos/modules/puppetlabs-motd/.bundle/gems/ruby/3.2.0/gems/puppet_litmus-1.4.0/lib/puppet_litmus/rake_tasks.rb:323:in `block (2 levels) in <top (required)>'
/Users/jordan.breen/Desktop/repos/modules/puppetlabs-motd/.bundle/gems/ruby/3.2.0/gems/rake-13.2.1/exe/rake:27:in `<top (required)>'
/Users/jordan.breen/.rbenv/versions/3.2.0/bin/bundle:25:in `load'
/Users/jordan.breen/.rbenv/versions/3.2.0/bin/bundle:25:in `<main>'
Tasks: TOP => litmus:tear_down
(See full trace by running task with --trace)

After:

bundle exec rake 'litmus:tear_down'                                                                              
HEAD is now at c511041 Merge pull request #647 from puppetlabs/release-prep
our_abs_node.net: success

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

This alters the request body payload object to correctly reference the
node job id which is required for tear_down of an abs node.
@jordanbreen28 jordanbreen28 requested a review from a team as a code owner July 11, 2024 10:13
Copy link
Member

@david22swan david22swan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@david22swan david22swan merged commit 5b26d04 into main Jul 11, 2024
7 checks passed
@david22swan david22swan deleted the cat-1958-fix_broken_abs_teardown branch July 11, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants