Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(CDPE-7069) Start caching trivy DBs in separate workflow #152

Merged

Conversation

abottchen
Copy link
Contributor

@abottchen abottchen commented Nov 14, 2024

In order to avoid ratelimiting issues when running trivy scans, all trivy runs need to run against a local copy of the DB (rather than downloading it each time). This commit adds a workflow to download the trivy DBs each morning.

Once this is in place and runs at least once, the trivy scans can be added back in and set to use the cache rather than download.

This PR is essentially following the documented steps at https://github.com/aquasecurity/trivy-action?tab=readme-ov-file#updating-caches-in-the-default-branch

@abottchen abottchen requested a review from a team as a code owner November 14, 2024 00:31
In order to avoid ratelimiting issues when running trivy scans,
all trivy runs need to run against a local copy of
the DB (rather than downloading it each time). This commit
adds a workflow to download the trivy DBs each morning.

Once this is in place and runs at least once, the trivy scans can be
added back in and set to use the cache rather than download.

This PR is essentially following the documented steps at
https://github.com/aquasecurity/trivy-action?tab=readme-ov-file#updating-caches-in-the-default-branch
@abottchen abottchen force-pushed the cdpe-7069/download-trivy-db-separately-puppet-dev-tools branch from 8e5108a to 3886c42 Compare November 14, 2024 00:46
Copy link

@owenbeckles owenbeckles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read over the documentation, and these changes look pretty straightforward and cohesive. LTGM!

@abottchen abottchen merged commit 948cf7c into main Nov 15, 2024
2 checks passed
@abottchen abottchen deleted the cdpe-7069/download-trivy-db-separately-puppet-dev-tools branch November 15, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants