Skip to content

Commit

Permalink
(PA-6896) Enable pie on RHEL 9 and up
Browse files Browse the repository at this point in the history
(PA-6896) remove the shared flag
  • Loading branch information
skyamgarp committed Aug 27, 2024
1 parent 38fc20b commit a1d005e
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
2 changes: 1 addition & 1 deletion configs/components/ruby-3.2.5.rb
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@
special_flags = " --prefix=#{ruby_dir} --with-opt-dir=#{settings[:prefix]} "

if settings[:supports_pie]
special_flags += " CFLAGS='#{settings[:cflags]}' LDFLAGS='#{settings[:ldflags]}' CPPFLAGS='#{settings[:cppflags]}' "
special_flags += " CFLAGS='-fPIC -fstack-protector-strong -fno-plt -O2' LDFLAGS='#{settings[:ldflags]}' CPPFLAGS='-fPIE #{settings[:cppflags]}' "
end

# Ruby's build process requires a "base" ruby and we need a ruby to install
Expand Down
6 changes: 5 additions & 1 deletion configs/projects/_shared-compiler-settings.rb
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
# are too old to support these flags.

if((platform.is_sles? && platform.os_version.to_i >= 15) ||
(platform.is_el? && platform.os_version.to_i == 8 && platform.architecture !~ /ppc64/) ||
(platform.is_debian? && platform.os_version.to_i >= 10) ||
(platform.is_ubuntu? && platform.os_version.to_i >= 22) ||
platform.is_fedora?
Expand All @@ -21,4 +20,9 @@
proj.setting(:cppflags, "-I#{proj.includedir} -D_FORTIFY_SOURCE=2")
proj.setting(:cflags, '-fstack-protector-strong -fno-plt -O2')
proj.setting(:ldflags, "-L#{proj.libdir} -Wl,-rpath=#{proj.libdir},-z,relro,-z,now")
elsif(platform.is_el? && platform.os_version.to_i >= 8)
proj.setting(:supports_pie, true)
proj.setting(:cppflags, "-I#{proj.includedir} -D_FORTIFY_SOURCE=2")
proj.setting(:cflags, '-fPIC -pie -fstack-protector-strong -fno-plt -O2')
proj.setting(:ldflags, "-L#{proj.libdir} -Wl,-rpath=#{proj.libdir},-z,relro,-z,now")
end

0 comments on commit a1d005e

Please sign in to comment.