Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PA-5633) Update hiera-eyaml #687

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

mhashizume
Copy link
Contributor

This commit update the hiera-eyaml component from 3.3.0 to 3.4.0, which enables compatibility with Ruby 3.2.

@mhashizume mhashizume requested review from a team as code owners June 28, 2023 21:36
@mhashizume
Copy link
Contributor Author

@AriaXLi
Copy link
Contributor

AriaXLi commented Jun 29, 2023

I'm not sure if I'm looking at CI wrong but it looks like in the vanagon generic builder run, hiera-eyaml 3.3.0 is being installed instead of 3.4.0:

touch rubygem-hiera-eyaml-unpack
touch rubygem-hiera-eyaml-patch
[ -d ./ ] || mkdir -p ./
touch rubygem-hiera-eyaml-configure
touch rubygem-hiera-eyaml-build
touch rubygem-hiera-eyaml-check
export GEM_HOME="/opt/puppetlabs/puppet/lib/ruby/vendor_gems" && \
export GEM_PATH="/opt/puppetlabs/puppet/lib/ruby/gems/2.7.0" && \
export RUBYLIB="/opt/puppetlabs/puppet/lib/ruby/vendor_ruby:" && \
cd ./ && \
/opt/puppetlabs/puppet/bin/gem install --no-document --local hiera-eyaml-3.3.0.gem
Successfully installed hiera-eyaml-3.3.0
1 gem installed

@mhashizume
Copy link
Contributor Author

mhashizume commented Jun 29, 2023

@AriaXLi Sorry, I think I linked to the wrong Vanagon generic builder job (I was juggling a few jobs yesterday).

This should be the correct job with one failure on AIX that went away on a reload: https://jenkins-platform.delivery.puppetlabs.net/job/platform_vanagon-generic-builder_vanagon-packaging_generic-builder/2101/

From the Ubuntu 18.04 cell in that job:

touch rubygem-hiera-eyaml-unpack
touch rubygem-hiera-eyaml-patch
[ -d ./ ] || mkdir -p ./
touch rubygem-hiera-eyaml-configure
touch rubygem-hiera-eyaml-build
touch rubygem-hiera-eyaml-check
export GEM_HOME="/opt/puppetlabs/puppet/lib/ruby/vendor_gems" && \
export GEM_PATH="/opt/puppetlabs/puppet/lib/ruby/gems/2.7.0" && \
export RUBYLIB="/opt/puppetlabs/puppet/lib/ruby/vendor_ruby:" && \
cd ./ && \
/opt/puppetlabs/puppet/bin/gem install --no-document --local hiera-eyaml-3.4.0.gem
Successfully installed hiera-eyaml-3.4.0
1 gem installed

@AriaXLi
Copy link
Contributor

AriaXLi commented Jun 29, 2023

Nice! LGTM, looks like you'll need to update your branch first though 😞

This commit update the hiera-eyaml component from 3.3.0 to 3.4.0, which
enables compatibility with Ruby 3.2.
@mhashizume mhashizume merged commit 8a5832c into puppetlabs:master Jun 29, 2023
2 checks passed
@mhashizume mhashizume deleted the PA-5633/master/hiera-eyaml branch June 29, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants