Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PA-4872) openssl 3 solaris 11 x86 #691

Merged

Conversation

cthorn42
Copy link
Collaborator

No description provided.

@cthorn42 cthorn42 requested review from a team as code owners June 30, 2023 17:59
@joshcooper
Copy link
Contributor

This needs rebasing due to merge conflicts.

@joshcooper
Copy link
Contributor

ah it looks like there's a merge commit in the feature branch. Could you instead rebase these commits onto upstream/master like

git reset --hard 52bfb2b               
git rebase 099a647 --onto upstream/master

You'll get some conflicts which need to be resolved, then

git rebase --continue
git push -f origin HEAD

The reason for going through this trouble is merge commits in pull requests make it difficult to understand git history. So the rebase workflow is preferred.

@cthorn42 cthorn42 force-pushed the PA-4872/openssl_3_solaris_11_x86 branch from 4e30a3b to 4ea52ef Compare July 6, 2023 19:01
@cthorn42
Copy link
Collaborator Author

cthorn42 commented Jul 6, 2023

Thanks for the help Josh, greatly appreciated.

This PR continues Aria's work for getting Solaris 11 x86-64 building openssl 3.
This uses OpenCSW's GCC to build openssl.
@cthorn42 cthorn42 force-pushed the PA-4872/openssl_3_solaris_11_x86 branch from 4ea52ef to c47a9e2 Compare July 6, 2023 22:06
Copy link
Contributor

@joshcooper joshcooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. If you haven't already, could you vanagon-generic-build these project & platform combinations:

❯ bx rake vanagon:component_diff -- -P agent-runtime-7.x -p all --from 46c127e --to HEAD  | grep 'Platform name'
Platform name: solaris-11-i386

❯ bx rake vanagon:component_diff -- -P agent-runtime-main -p all --from 46c127e --to HEAD  | grep 'Platform name' | grep -v solaris-10
Platform name: solaris-11-sparc
Platform name: solaris-11-i386

We can ignore solaris 10 on agent-runtime-main

@cthorn42
Copy link
Collaborator Author

cthorn42 commented Jul 7, 2023

Here is the solaris-11-i386 for agent-runtime-7.x: https://jenkins-platform.delivery.puppetlabs.net/view/vanagon-generic-builder/job/platform_vanagon-generic-builder_vanagon-packaging_generic-builder/2118/BUILD_TARGET=solaris-11-i386,SLAVE_LABEL=k8s-worker/
and here is the agent-runtime-main job: https://jenkins-platform.delivery.puppetlabs.net/view/vanagon-generic-builder/job/platform_vanagon-generic-builder_vanagon-packaging_generic-builder/2116/
The i386 cell failed with the rubygems-ffi failure that is ticketed, and the sparc cell failed. I guess that should be suspected since we haven't landed any changes for that yet?

Copy link
Contributor

@joshcooper joshcooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for running those. I'm not concerned about the solaris 11 sparc failures in agent-runtime-main

@joshcooper joshcooper changed the title Pa 4872/openssl 3 solaris 11 x86 (PA-4872) openssl 3 solaris 11 x86 Jul 7, 2023
@joshcooper joshcooper merged commit 7029ef2 into puppetlabs:master Jul 7, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants