Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated packages for bolt release #888

Closed
wants to merge 15 commits into from

Conversation

alex501212
Copy link
Contributor

@alex501212 alex501212 commented Aug 6, 2024

Updates packages for ruby 3 + puppet 8

@alex501212 alex501212 requested review from a team as code owners August 6, 2024 10:46
@alex501212 alex501212 marked this pull request as draft August 6, 2024 11:04
@alex501212 alex501212 changed the title updated packages updated packages for bolt release Aug 6, 2024
@alex501212 alex501212 marked this pull request as ready for review August 6, 2024 11:37
@donoghuc
Copy link
Contributor

donoghuc commented Aug 7, 2024

Not quite following the reverts etc you made. I was pointing out that when you ad a new case you must also implement logic to select that case conditionally. One option would be to explicitly call it out in project files, however i'm not convinced that is the best long term solution. Instead i think we should investigate switching on ruby version.

@joshcooper
Copy link
Contributor

Before merging, could you squash commits and remove any merge commits from your feature branch?

Also I recommend running this rake task to show how each project in this repo will be modified for a given platform:

$ bundle exec rake vanagon:component_diff -- -P all -p el-9-x86_64 --from upstream/master --to HEAD

For the most accurate results, you'll want to rebase your feature branch onto upstream/master (where upstream is the remote for puppetlabs)

@donoghuc
Copy link
Contributor

donoghuc commented Aug 9, 2024

Thanks @joshcooper , i'm going to take over this work. I'll likely just start a new PR.

@alex501212 alex501212 closed this Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants