Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PA-6881) Configure a default gem_uninstall command #910

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

donoghuc
Copy link
Contributor

@donoghuc donoghuc commented Sep 6, 2024

With the addition logic in #901 for deduplicating rexml gems an inadvertant requirement was imposed on projects to define a gem_uninstall command. This command should be ubiquitous (especially with impending ruby 3 only streams) so instead of requiring all projects to configure it a default is added. This setting is still configurable at a project level, but is not required.

With the addition logic in puppetlabs#901 for deduplicating rexml gems an inadvertant requirement was imposed on projects to define a `gem_uninstall` command. This command should be ubiquitous (especially with impending ruby 3 only streams)  so instead of requiring all projects to configure it a default is added. This setting is still configurable at a project level, but is not required.
@donoghuc donoghuc requested review from a team as code owners September 6, 2024 18:55
@donoghuc
Copy link
Contributor Author

donoghuc commented Sep 6, 2024

Build a bolt-server runtime just to double check:

(base) ➜  puppet-runtime git:(default-gem_uninstall) ✗ bundle exec vanagon build pe-bolt-server-runtime-main sles-15-x86_64
...
cp pe-bolt-server-runtime-main-202409030.1.gdedd733.sles-15-x86_64.tar.gz output
sha1sum output/pe-bolt-server-runtime-main-202409030.1.gdedd733.sles-15-x86_64.tar.gz > output/pe-bolt-server-runtime-main-202409030.1.gdedd733.sles-15-x86_64.tar.gz.sha1
Warning: Permanently added 'eared-principle.delivery.puppetlabs.net' (ED25519) to the list of known hosts.

Installs cleanly.

@joshcooper joshcooper merged commit bb18b98 into puppetlabs:master Sep 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants