(CAT-1348)-Conversion of erb to epp templates except mod or vhost dir… #2448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praj1001
requested review from
bastelfreak,
ekohl,
smortex and
a team
as code owners
praj1001
force-pushed
the
CAT-1348_erb_to_epp_except_in_mod_vhost_directory
branch
2 times, most recently
from
d8e5e67
to
e605fce
Compare
|
FYI: I did start https://github.com/ekohl/erb2epp and ekohl/erb2epp#4 does improve things a bit, but I haven't finished that review. Perhaps it can help you. |
ekohl
reviewed
Sep 4, 2023
praj1001
force-pushed
the
CAT-1348_erb_to_epp_except_in_mod_vhost_directory
branch
5 times, most recently
from
8e8bd66
to
88e941c
Compare
dinesh-gujar
force-pushed
the
CAT-1348_erb_to_epp_except_in_mod_vhost_directory
branch
2 times, most recently
from
9775b39
to
a9b84c3
Compare
dinesh-gujar
force-pushed
the
CAT-1348_erb_to_epp_except_in_mod_vhost_directory
branch
from
5abf162
to
be506d4
Compare
praj1001
deleted the
CAT-1348_erb_to_epp_except_in_mod_vhost_directory
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Conversion of ERB templates to EPP for apache module. It doesn't converts any erb template present in mod or vhost directory.
Additional Context
Related Issues (if any)
Checklist
puppet apply)