define Enum on supported encryption types for postgresql_password

[figless]

Summary

This PR fixes 1575

Additional Context

Related Issues (if any)

Checklist

I was hitting 1575 when using a Deferred password. With this fix, puppet creates the database as before (v9.2.0)

postgresql::server::db { $db_name:
      user     => $db_username,
      password => Deferred('unwrap', [$db_password]),
}

[CLAassistant]

All committers have signed the CLA.

[ekohl]

We already have defined this as an enum:

puppetlabs-postgresql/types/pg_password_encryption.pp

Line 2 in 05a7809

type Postgresql::Pg_password_encryption = Enum['md5', 'scram-sha-256']

And it's used in multiple places now, so this would risk them going out of sync. I'd at least expect a comment in both places to remind people to keep them in sync.

[figless]

We already have defined this as an enum:

puppetlabs-postgresql/types/pg_password_encryption.pp

Line 2 in 05a7809

type Postgresql::Pg_password_encryption = Enum['md5', 'scram-sha-256']

And it's used in multiple places now, so this would risk them going out of sync. I'd at least expect a comment in both places to remind people to keep them in sync.

I've added a comment to both files.

[bastelfreak]

Is there a chance you can add a test with Deferred(), to ensure this doesn't break in the future?

[figless]

Is there a chance you can add a test with Deferred(), to ensure this doesn't break in the future?

Sure - i've copied spec/acceptance/db_spec.rb to spec/acceptance/db_deferred_spec.rb and configured the test to use a Deferred password.

[figless]

The previous code in db_deferred_spec.rb failed the CI, even though it was essentially a copy from db_spec.rb....
I have adapted the code, which now passes locally.