-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updating containers and enabling restic support for azure #241
Open
anthonysomerset
wants to merge
11
commits into
puppetlabs:master
Choose a base branch
from
anthonysomerset:restic_azure
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonysomerset
requested review from
davidphay and
ldaneliukas
as code owners
January 14, 2025 10:24
…ations of various containers
ldaneliukas
requested changes
Jan 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added some small things to review, great work 👍
correct date for changelog Co-authored-by: Linas Daneliukas <linas@daneliukas.eu>
Co-authored-by: Linas Daneliukas <linas@daneliukas.eu>
Co-authored-by: Linas Daneliukas <linas@daneliukas.eu>
Co-authored-by: Linas Daneliukas <linas@daneliukas.eu>
Co-authored-by: Linas Daneliukas <linas@daneliukas.eu>
…he data should exist in the secret
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulling the list of changes from CHANGELOG
the various updates should be self explanatory but to specifically point out the changing container URL and version format for puppetserver/puppetdb as VoxPupuli are deprecating the old container URL in 2025-02
Restic now supports defining an existingSecret (but the chart will not provision it if you do) so that you can securely define the access parameters in a secret going forwards rather than Helm Chart values, the old method still works today (for S3 buckets only!), README is updated to show this with examples
Restic now also supports Azure Workload Identity and Azure Blob storage for backup repo, readme is updated to show an example but configuring workload identity e.g. the configuration of a managed identity and assigning permissions is not detailed in the readme
I have also made some additional notes in the readme to talk about upgrading puppet to v8 as well as clarify the previous notes related to updating the Helm Chart version to avoid confusion
In theory (but untested) the new existingSecret method for restic config allows a user to set any compatible environment value for restic and could therefore support additional backend repos, I have only tested Azure Blob Storage
as all of these changes remain backwards compatible i have only bumped version to 9.6.0 rather than 10.0.0