Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating containers and enabling restic support for azure #241

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

anthonysomerset
Copy link
Contributor

@anthonysomerset anthonysomerset commented Jan 14, 2025

Pulling the list of changes from CHANGELOG

the various updates should be self explanatory but to specifically point out the changing container URL and version format for puppetserver/puppetdb as VoxPupuli are deprecating the old container URL in 2025-02

Restic now supports defining an existingSecret (but the chart will not provision it if you do) so that you can securely define the access parameters in a secret going forwards rather than Helm Chart values, the old method still works today (for S3 buckets only!), README is updated to show this with examples

Restic now also supports Azure Workload Identity and Azure Blob storage for backup repo, readme is updated to show an example but configuring workload identity e.g. the configuration of a managed identity and assigning permissions is not detailed in the readme

I have also made some additional notes in the readme to talk about upgrading puppet to v8 as well as clarify the previous notes related to updating the Helm Chart version to avoid confusion

In theory (but untested) the new existingSecret method for restic config allows a user to set any compatible environment value for restic and could therefore support additional backend repos, I have only tested Azure Blob Storage

as all of these changes remain backwards compatible i have only bumped version to 9.6.0 rather than 10.0.0

Copy link
Collaborator

@ldaneliukas ldaneliukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added some small things to review, great work 👍

CHANGELOG.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
values.yaml Outdated Show resolved Hide resolved
anthonysomerset and others added 6 commits January 16, 2025 23:39
correct date for changelog

Co-authored-by: Linas Daneliukas <linas@daneliukas.eu>
Co-authored-by: Linas Daneliukas <linas@daneliukas.eu>
Co-authored-by: Linas Daneliukas <linas@daneliukas.eu>
Co-authored-by: Linas Daneliukas <linas@daneliukas.eu>
Co-authored-by: Linas Daneliukas <linas@daneliukas.eu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants