Raise minimum version to Puppet 7.11

[ekohl]

This avoids the need to have any version specific code and it's the only thing that's testing in CI.

Right now still a draft since I'm not quite sure how it should turn out. Includes #67

[nabertrand]

We utilize the manifest setting when testing our control repository to ensure anything in the environment site.pp is included during tests as shown in the spec/spec_helper.rb fragment below. Is there a better way to accomplish this?

RSpec.configure do |c|
  c.manifest = File.join(File.dirname(File.dirname(__FILE__)), 'manifests', 'site.pp')
end

[ekohl]

The reason I dropped it is that the manifest setting is gone. At least in https://www.puppet.com/docs/puppet/7/configuration.html I can no longer find it. I suspect environments now determine this via environment.conf. But feedback is welcome. I may have missed something.

[ekohl]

I'm pretty sure I ran into a situation myself where I needed to the manifest, so I think you're right that this should remain.

[nabertrand]

It might be the case that Puppet doesn't use this setting directly anymore, but it is used by rspec-puppet internally to prepend additional Puppet code to test:

rspec-puppet/lib/rspec-puppet/support.rb

Line 25 in d21b570

[site_pp_str, pre_cond, test_manifest(type, manifest_opts), post_cond].compact.join("\n")

rspec-puppet/lib/rspec-puppet/support.rb

Lines 153 to 166 in d21b570

	def site_pp_str
	return '' unless (path = adapter.manifest)
	if File.file?(path)
	File.read(path)
	elsif File.directory?(path)
	# Read and concatenate all .pp files.
	Dir[File.join(path, '*.pp')].sort.map do |f|
	File.read(f)
	end.join("\n")
	else
	''
	end
	end

[ekohl]

Yes, I found this in our Infra repo where I use it to test our environment, rather than individual modules: https://github.com/theforeman/foreman-infra/blob/9d05130a5ada4fd734898b6e14b93bd292c92717/puppet/spec/spec_helper.rb#L29

[jordanbreen28]

thanks for doing most of the heavy lifting @ekohl, closing in favour of #73