Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) - remove irrelevant readme sections #79

Merged
merged 2 commits into from
Oct 11, 2023

Conversation

jordanbreen28
Copy link

@jordanbreen28 jordanbreen28 commented Oct 11, 2023

Summary

trusted_server_facts config setting was removed in Puppet 6.x and from rspec-puppet in #73.

trusted_node_data was also removed in puppet 4.x+ and from rspec-puppet in #73.

This removes the now irrelevant readme sections.

Additional Context

Add any additional context about the problem here.

  • Root cause and the steps to reproduce. (If applicable)
  • Thought process behind the implementation.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

@jordanbreen28 jordanbreen28 marked this pull request as ready for review October 11, 2023 10:16
@jordanbreen28 jordanbreen28 requested review from bastelfreak and a team as code owners October 11, 2023 10:16
@jordanbreen28 jordanbreen28 force-pushed the maint-remove_readme_on_trusted_server_facts branch from 9e730f1 to 4f0cbfe Compare October 11, 2023 10:16
@jordanbreen28 jordanbreen28 changed the title (maint) - remove readme section on trusted_server_facts (maint) - remove irrelevant readme sections Oct 11, 2023
@jordanbreen28 jordanbreen28 force-pushed the maint-remove_readme_on_trusted_server_facts branch from 4f0cbfe to a43e072 Compare October 11, 2023 10:19
@GSPatton GSPatton merged commit d584976 into main Oct 11, 2023
5 checks passed
@GSPatton GSPatton deleted the maint-remove_readme_on_trusted_server_facts branch October 11, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants