Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: aws profile prompt #348

Merged
merged 4 commits into from
Feb 16, 2024
Merged

feat: aws profile prompt #348

merged 4 commits into from
Feb 16, 2024

Conversation

edouard-lopez
Copy link
Member

@edouard-lopez edouard-lopez commented Feb 16, 2024

related: supersed #346

Heavy work was done by @kwigley 🧠


Adds the currently active aws profile to prompt.

How to test pre-release?

☠️ Feature can be unstable and break your prompt!

fisher install pure-fish/pure@feat/foo_feature # branch name
set --universal pure_enable_foo_feature true

First contribution?

Check the 👍 contributing guide for code and naming conventions.

Specs

New config in conf.d/pure.fish

_pure_set_default pure_enable_aws_profile true
_pure_set_default pure_symbol_aws_profile "🤯"

Documentation

Usage

set --universal pure_enable_aws_profile true

Acceptance Checks

  • Documentation is up-to-date:
    • Add entry in feature list of README.md ;
    • Add entry in features' overview in docs/ ;
    • Add section in feature list to document
      • Features' flag ;
      • Prompt symbol ;
  • Default are defined in conf.d/pure.fish for:
    • Feature flag ;
    • Symbol ;
  • Tests are passing (I can help you 🤗 ):
  • Customization is available ;
  • Feature is implemented.

@edouard-lopez edouard-lopez changed the title kwigley master feat: aws profile prompt Feb 16, 2024
@edouard-lopez edouard-lopez mentioned this pull request Feb 16, 2024
14 tasks
@edouard-lopez edouard-lopez merged commit 7f713ca into master Feb 16, 2024
6 checks passed
@edouard-lopez edouard-lopez deleted the kwigley-master branch February 16, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants