PureInput Value Patch #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security vulnerability is causing error on builds
I'm assuming InnerValue was to safely control the component's bound value without exposing the parent value. Trouble is, we never properly updated this. Rather than fix that, I opted to abuse the fact that we wrapped the bind in the first place, since TextValue only needs to be read-only and OnChange/OnInput pass it up the parent bind
codymullins
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PureInput Value Patch
Description
Bumps System.Text.Json to 8.0.5, unrelated to bug
When PureInput's binding value changes, the content does not update.
This was caused by the wrapper value innerValue only being assigned on creation.
To minimize changes, I abused the fact that TextValue's only purpose is to serve as a bind target 'getter' to minimize code changes.
TextValue now directly exposes the underlying Value parameter, while OnChange/OnInput update Value parameter via ValueChanged