Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to ps 0.12 #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shmish111
Copy link

No description provided.

@CLAassistant
Copy link

CLAassistant commented May 2, 2019

CLA assistant check
All committers have signed the CLA.

"purescript-web-file": "^2.0.0",
"purescript-web-dom": "^2.0.0",
"purescript-web-storage": "^3.0.0",
"purescript-web-events": "^2.0.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think something is wrong somewhere if you were forced to make resolutions - maybe some other dependency or dependencies that need updating first - I don't mind making resolutions in projects / apps that aren't going to be depended upon, but having it in a library is going to cause issues for anyone who wants to rely on it too.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hate bower so much. ok I can take a look, I just updated everything to latest

Copy link
Member

@garyb garyb May 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use npm-check-updates to bump everything to the latest version (you can use a flag to run it on bower too) if you don't already know about that. It doesn't help with figuring out where the conflicts are when bower has a meltdown unfortunately, but it's useful to take some of the pain out!

"pulp": "^9.0.1",
"purescript": "^0.10.1",
"rimraf": "^2.5.4"
"bower": "^1.8.4",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding bower as an explicit local dependency doesn't work too well, since it complains if it's not the most up to date version at all times.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok I can remove. this was when I was struggling to get yarn run example working but now it does.

@garyb
Copy link
Member

garyb commented May 2, 2019

Thanks! I'll take more of a look when the dependency stuff is figured out 🙂

@shmish111
Copy link
Author

Hmm, the problem is halogen 4.0.0:

Unable to find a suitable version for purescript-web-html, please choose one by typing one of the numbers below:
    1) purescript-web-html#^1.0.0 which resolved to 1.2.0 and is required by purescript-halogen-vdom#3.0.0, purescript-web-clipboard#1.0.0, purescript-web-uievents#1.1.0
    2) purescript-web-html#^2.0.0 which resolved to 2.0.1 and is required by purescript-ace#7.0.0, purescript-web-uievents#2.0.0

How would we proceed with this? Halogen 4.1.0? What should I do (I feel I can ask since you own all these repos 😄 )

@shmish111
Copy link
Author

@garyb any update on what you want me to do here? Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants