Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Summer of Code project summary: Implementing new spectral corrections in pvlib #2065

Open
RDaxini opened this issue May 24, 2024 · 5 comments · Fixed by #2088
Open
Labels
GSoC Contributions related to Google Summer of Code.

Comments

@RDaxini
Copy link
Contributor

RDaxini commented May 24, 2024

Introduction

This issue summarises the ongoing and completed work for the GSoC 2024 programme with pvlib.

The project I am undertaking relates to an issue raised earlier this year. The official abstract for the project can be found here. This project is being carried out under the supervision of @AdamRJensen and @kandersolar

In summary, the aim of the project is to implement new spectral correction models in pvlib, as well as examples of their application and use. In addition to updating this issue as the project progresses, detailed updates on the project will also be shared in blog posts. Major milestone updates will be shared on my LinkedIn page as well.

Plan

The current overall project plan is described below.

  1. Three new models are planned for development and implementation:
  1. A combined example to demonstrate the use of the new models and application in the overall modelling pipeline will be developed.

As the project develops I will link these tasks to individual issues and pull requests.

Issues

Open:
#2125 (suggestion to split mismatch.py)
#1950 (general issue, add new spectral factor models)
#2086 (update spectral_factor_firstsolar)
#2065 (this one)
Closed:
#2087 (add JRC spectral factor model)
#2115 (update SAPM spectral factor docs)
#2107 (add spectral factor example),

PRs


Any feedback on the project is certainly more than welcome. Using github and contributing to open-source software is completely new to me so I am looking forward to learning about this so that I can contribute to pvlib not only through this project but also in future.

Dax

@kandersolar kandersolar added the GSoC Contributions related to Google Summer of Code. label May 24, 2024
@markcampanelli
Copy link
Contributor

As part of the documentation of a growing number of methods, it might be helpful if a “overview” table of spectral-correction method vs. required+optional inputs were added. This way consumers would be able to get a quicker idea of what information/data is needed to apply each correction. The timescale over which the correction is applied could also be a factor (although maybe they are all the same at this point).

@RDaxini
Copy link
Contributor Author

RDaxini commented May 27, 2024

@markcampanelli I think that is a good suggestion. I tried to achieve something similar with Table 10 in this study; is that the sort of thing you had in mind? Timescale is a good point too. I have had a paper examining this issue under review for a while so maybe/hopefully something will come out of that soon that I can implement into this work.

@adriesse
Copy link
Member

@didierthevenard

@markcampanelli
Copy link
Contributor

@markcampanelli I think that is a good suggestion. I tried to achieve something similar with Table 10 in this study; is that the sort of thing you had in mind? Timescale is a good point too. I have had a paper examining this issue under review for a while so maybe/hopefully something will come out of that soon that I can implement into this work.

@RDaxini Yes. Depending on your time, you could at a bare minimum reference your paper with table 10. If time permits, then you could perhaps provide a “translation” of that table into something more specific to pvlib’s variable names and functions.

BTW: Your timescale-focused paper also sounds like an interesting read 🙂. Good luck working it through the process!

@kandersolar
Copy link
Member

@RDaxini #2088 got automatically linked to this issue based on its description, so merging that PR automatically closed this issue. Check out https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

Try "see also #XXX" or some other phrasing to prevent the automatic linkage next time :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSoC Contributions related to Google Summer of Code.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants