Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add JRC spectral factor model #2087

Closed
RDaxini opened this issue Jun 15, 2024 · 3 comments · Fixed by #2088
Closed

add JRC spectral factor model #2087

RDaxini opened this issue Jun 15, 2024 · 3 comments · Fixed by #2088
Labels
enhancement GSoC Contributions related to Google Summer of Code.
Milestone

Comments

@RDaxini
Copy link
Contributor

RDaxini commented Jun 15, 2024

Is your feature request related to a problem? Please describe.
The PVSPEC model for the spectral mismatch factor was recently merged (#2072) but an alternative parameterisation of the mismatch factor as a function of air mass and clear sky index is available, namely the JRC model. I think providing pvlib users with a choice of model would be a valuable enhancement.

Describe the solution you'd like
Implement JRC model using the PVSPEC function as a template.

Additional context
Some questions:

  1. Citation for the clear sky model in the JRC publication is:

"K. Scharmer and J. Greif (eds.), “The European Solar Radiation Atlas, Vol 2: Database and Exploitation Software”, Presses de l’École des Mines, Paris (2000)"

and

"M. Šúri and J. Hofierka. “A new GIS-based solar radiation model and its application to photovoltaic assessments”, Transactions in GIS, 8 (2004), pp. 175-190".

In the PVSPEC paper and the pvlib implementation:

"Rigollier, C., Bauer, O. and Wald, L., 2000. On the clear sky model of the ESRA—European Solar Radiation Atlas—with respect to the Heliosat method. Solar Energy, 68(1), pp.33-48.".

I think these are the same ESRA model (?) ---if so, which citation should I use?

  1. As far as I can tell, the model used to estimate air mass is not stated, nor whether it is relative or absolute air mass. In the docs, would it suffice just to write something like "the model used to estimate the air mass (denoted AM) is not stated." ?

This issue links to my GSoC project (#2065) and this issue #1950

@echedey-ls
Copy link
Contributor

As far as I can tell, the model used to estimate air mass is not stated, nor whether it is relative or absolute air mass.

The measurements facility is roughly 220m above sea level, so the difference in absolute and relative AM may not be that significant? Talking from my unknowledgeable point of view. We could maybe ask the authors?

@kandersolar kandersolar added enhancement GSoC Contributions related to Google Summer of Code. labels Jun 17, 2024
@echedey-ls
Copy link
Contributor

I've seen you've changed from an unqualified airmass to airmass_absolute in the PR. Have you got into contact with the authors, have you found that information anywhere or did I convince you? My guess intentions just were to speed up some initial work.

@RDaxini
Copy link
Contributor Author

RDaxini commented Jun 20, 2024

@echedey-ls I have already reached out but no response yet. I will leave it as airmass as that is what is written in the paper. No reason to assume otherwise. Citations of the manuscript do the same, e.g. https://doi.org/10.1016/j.solener.2013.05.011

@kandersolar kandersolar added this to the v0.11.0 milestone Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement GSoC Contributions related to Google Summer of Code.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants