Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/sphinx/source/reference
for API changes.docs/sphinx/source/whatsnew
for all changes. Includes link to the GitHub Issue with:issue:`num`
or this Pull Request with:pull:`num`
. Includes contributor name and/or GitHub username (link with:ghuser:`user`
).remote-data
) and Milestone are assigned to the Pull Request and linked Issue.This discussion on the pvlib Google group showed code for translating the content of a PVsyst OND file to parameters for
inverter.sandia
. An OND file has sufficient information to fit thesandia
inverter model to get the four empirical parameters C0, C1, C2 and C3.Do we think a translator (
ond_to_sandia_inv
) is useful? I put it inpvlib.inverter
because the translation is specific to the target model (sandia) and would be different for the ADR inverter model.There are some content of the OND file (number of MPPT inputs, for example) that are useful but not for the inverter functions, rather, for the higher-level modeling objects (number of Arrays connected to an inverter). I'm not sure what to do with these (yet).
I don't know if this example OND file is typical of all files. Reading this file points out some possible improvements:
iotools.panond.read_panond
, the OND structure is returned in this pattern{'PVObject_': data}
, wheredata
is a dict that has actual values.read_panond
default to UTF-8 encoding?inverter.fit_sandia
says it accepts "array-like" inputs. Should "array-like" include lists? They don't work.