Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floating PV gallery example #2110

Merged
merged 59 commits into from
Jul 8, 2024

Conversation

IoannisSifnaios
Copy link
Contributor

@IoannisSifnaios IoannisSifnaios commented Jun 27, 2024

  • Relevant to Google Summer of Code: Floating PV #2068
  • I am familiar with the contributing guidelines
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

Addition of gallery example for the use of the PVSyst cell temperature model for floating PV. Essentially, it implements different heat loss coefficients compared to the default values of the PVSyst model.

Information was taken from these papers: 1, 2, 3

The created gallery example can be accessed here.

@kandersolar kandersolar added this to the v0.11.1 milestone Jun 27, 2024
@kandersolar kandersolar added documentation GSoC Contributions related to Google Summer of Code. labels Jun 27, 2024
@IoannisSifnaios IoannisSifnaios marked this pull request as ready for review June 27, 2024 17:15
@IoannisSifnaios
Copy link
Contributor Author

Hi @lmicheli! Feel free to give any feedback on this!

@kandersolar
Copy link
Member

For any reviewers, here's a link to what the gallery page will look like: https://pvlib-python--2110.org.readthedocs.build/en/2110/gallery/floating-pv/plot_floating_pv_cell_temperature.html

@IoannisSifnaios having seen the lovely table in the example, I am left wondering what the simulated temperature will look like using all those other parameter sets. What do you think about having the example code iterate through all the sets of coefficients and plotting all of the results instead of just two?

@lmicheli
Copy link

Hi all, not sure if this is the right way to proceed.... Here some thoughts on the gallery page (great job):

  • I believe reference [2] is not correct. 86.5 W/m2K is the U value reported in a different work from the same group: https://doi.org/10.1002/pip.3451
  • In [2], they report U-values of 71 W/m2K. Also, they use the water temperature instead of the air temperature (this should be mentioned)
  • in [1], they report both single U-values as well as Uc and Uv. I think, as for LPV, the single U-value is most commonly employed. So I would suggesting adding the single U-values as well (or replacing the Uc/Uv with the single values). I do not remember if the authors find any significant difference between the two approaches.

Copy link
Contributor

@echedey-ls echedey-ls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicking table rendering, description and fixing some typos.

It would be nice to add an entry under the Documentation subsection in the appropriate whatsnew, and give credits to @lmicheli for reviewing. Nice job with the example.

Co-authored-by: Echedey Luis <80125792+echedey-ls@users.noreply.github.com>
@IoannisSifnaios IoannisSifnaios marked this pull request as draft July 1, 2024 12:10
IoannisSifnaios and others added 2 commits July 1, 2024 14:10
Co-authored-by: Echedey Luis <80125792+echedey-ls@users.noreply.github.com>
Co-authored-by: Echedey Luis <80125792+echedey-ls@users.noreply.github.com>
IoannisSifnaios and others added 9 commits July 4, 2024 10:24
Co-authored-by: RDaxini <143435106+RDaxini@users.noreply.github.com>
Co-authored-by: RDaxini <143435106+RDaxini@users.noreply.github.com>
Co-authored-by: RDaxini <143435106+RDaxini@users.noreply.github.com>
Co-authored-by: RDaxini <143435106+RDaxini@users.noreply.github.com>
Co-authored-by: RDaxini <143435106+RDaxini@users.noreply.github.com>
Co-authored-by: RDaxini <143435106+RDaxini@users.noreply.github.com>
IoannisSifnaios and others added 18 commits July 6, 2024 15:02
Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>
Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>
Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>
Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>
Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>
Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>
Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>
Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>
Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>
Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>
Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>
Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>
Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>
Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>
Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>
Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>
Copy link
Member

@kandersolar kandersolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @IoannisSifnaios and reviewers!

@kandersolar kandersolar merged commit 6f5afa9 into pvlib:main Jul 8, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation GSoC Contributions related to Google Summer of Code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants