ignore pages with parameters #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wouldn't your solution also remove all Edit and View pages? Why doesn't |
|
Yes you are absolutely right Only problem that's remaining is that plugins with custom pages that using parameters will automatically not work and users can't add |
|
Sorry, I am wrong. Edit and View Pages are registered via the ResourceActiion. So this should work for them, too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: if you have a Filament page with a parameter like this
protected static ?string $slug = 'test/{parameter}';it will break the plugin. Even if you set shouldRegisterSpotlight to false in your page.Solution: this code just ignores all pages with parameters
Discord user jamiecee20 brought this to my attention as it breaks my plugin (https://discord.com/channels/883083792112300104/1252364577228853389)