Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add decryption to the cat operation #61

Merged
merged 6 commits into from
Dec 8, 2024

Conversation

EmperorArthur
Copy link
Contributor

@EmperorArthur EmperorArthur commented Oct 16, 2024

I recently needed to decrypt a PDF file, and found the program would just error. This resolves that issue.

  • Ads an optional password parameter to the "cat" operation. Allowing decryption.
  • Makes decryption errors more readable for end-users.

@ouqilbo
Copy link

ouqilbo commented Oct 23, 2024

Love this. Started using pdfly a week ago and I was about to stop because I had to manipulate a password protected pdf

@Lucas-C
Copy link
Member

Lucas-C commented Oct 29, 2024

Hi
Thank you for your contribution @EmperorArthur 👍
I think this PR needs to be rebased on main.
And pdfly/cat.py needs to be pretty-formatted with black

@ouqilbo
Copy link

ouqilbo commented Dec 4, 2024

Hey @EmperorArthur, could you please proceed with the pr and follow the previous suggestions? As I already said, this is really beneficial when in need to use password protected pdfs.

@MartinThoma MartinThoma changed the title Add decryption to the cat operation ENH: Add decryption to the cat operation Dec 8, 2024
pdfly/cat.py Outdated Show resolved Hide resolved
pdfly/cli.py Outdated Show resolved Hide resolved
pdfly/cat.py Outdated Show resolved Hide resolved
pdfly/cat.py Outdated Show resolved Hide resolved
@MartinThoma MartinThoma merged commit a18ae8a into py-pdf:main Dec 8, 2024
9 checks passed
@MartinThoma
Copy link
Member

Thank you for your contribution @EmperorArthur 🙏

@MartinThoma
Copy link
Member

@ouqilbo This will be part of the next release. You can always install the current development version like this: https://pdfly.readthedocs.io/en/latest/user/installation.html#development-version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants