fix: make sure netcdf exporters can handle list of timesteps #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #369 +/- ##
==========================================
+ Coverage 83.33% 83.52% +0.18%
==========================================
Files 161 159 -2
Lines 12370 12575 +205
==========================================
+ Hits 10309 10503 +194
- Misses 2061 2072 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dnerini
requested changes
Jul 9, 2024
There was a problem hiding this comment.
Great contribution @RubenImhoff ! I left few very minor comments
dnerini
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that the netcdf exporters can handle a list of timesteps next to just an integers number of timesteps. One of pysteps' functionalities is that you can give it specific output timesteps for which the nowcasts should be stored, but it was not yet possible to store these output timesteps as such in a netCDF. This PR tries to fix that.