Add option to smooth radar mask #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o remove hard edge from blending with NWP
…n of another parameter called 'create_smooth_radar_mask'. The actual implimentation of the code can be found in the blending utils
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #379 +/- ##
==========================================
+ Coverage 83.52% 83.67% +0.15%
==========================================
Files 159 159
Lines 12575 12649 +74
==========================================
+ Hits 10503 10584 +81
+ Misses 2072 2065 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dnerini
requested changes
Jul 17, 2024
|
@RubenImhoff suggested to add some figures of the effect of the smooth mask on the final product. Below I attach a figure with 3 version: one without a smooth edge (current product), one with a smooth edge with a maximum range of 50 px (=50km) and one with a max range of 80km. |
…an blended mask. Fixed by aplying the smooth mask to the lagrangian blended reference nowcast (R_pm_blended)
dnerini
reviewed
Jul 17, 2024
RubenImhoff
requested changes
Jul 18, 2024
|
I think we're almost there - I'm working on adding some extra tests. :) |
RubenImhoff
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution for #377
Addition done by adding a cv2 based method in blending.utils.py called compute_smooth_dilated_mask(...).
This function can be used in the blending.steps.forecast by changing the create_smooth_radar_mask parameter to True, standard this is put to False to not create conflicts with existing code.