-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lambert_conformal_conic projection #380
Conversation
pysteps.io.exporters._convert_proj4_to_grid_mapping()
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #380 +/- ##
==========================================
+ Coverage 83.52% 83.64% +0.11%
==========================================
Files 159 159
Lines 12575 12598 +23
==========================================
+ Hits 10503 10537 +34
+ Misses 2072 2061 -11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
code coverage is complaining, could you maybe include a simple test for the new lines of code that you've added? |
I am on it. The test function will be added and should be compatible with different projections strings. To achieve this, I need the projection strings and expected output for the other projections (i.e., "stere" and "aea").
if you have pro4str for the 2 projection types mentioned above, that would be great ;)
function: pysteps_io.exporters._convert_proj4_to_grid_mapping()
From: "Daniele Nerini" ***@***.***>
To: "pySTEPS/pysteps" ***@***.***>
Cc: "FelixE91" ***@***.***>, "Author" ***@***.***>
Sent: Wednesday, July 17, 2024 2:06:54 PM
Subject: Re: [pySTEPS/pysteps] Add lambert_conformal_conic projection (PR #380)
code coverage is complaining, could you maybe include a simple test for the new lines of code that you've added?
—
Reply to this email directly, [ #380 (comment) | view it on GitHub ] , or [ https://github.com/notifications/unsubscribe-auth/BJ33FMF6PLLSTQUCGQ2IYZTZMZM55AVCNFSM6AAAAABLAIPZ2GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZTGE3DENBQGY | unsubscribe ] .
You are receiving this because you authored the thread. Message ID: ***@***.***>
|
Function added to tests/test_exporters.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, thanks!
Add lambert_conformal_conic projection pysteps.io.exporters._convert_proj4_to_grid_mapping()
Fix to issue #378