Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support for timesteps list in case model has rain but radar does not #411

Merged
merged 4 commits into from
Jul 25, 2024

Conversation

mats-knmi
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.88%. Comparing base (07a5aa8) to head (39d8c0d).

Files Patch % Lines
pysteps/blending/steps.py 88.23% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #411      +/-   ##
==========================================
+ Coverage   83.82%   83.88%   +0.06%     
==========================================
  Files         160      160              
  Lines       12788    12785       -3     
==========================================
+ Hits        10719    10725       +6     
+ Misses       2069     2060       -9     
Flag Coverage Δ
unit_tests 83.88% <92.30%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RubenImhoff
Copy link
Contributor

Thanks for this extra fix related to #368, @mats-knmi!

@dnerini dnerini merged commit 8bec82e into master Jul 25, 2024
10 checks passed
@dnerini dnerini deleted the fix-timesteps-as-list branch July 25, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants