Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Basic Reservoir Model #30

Merged
merged 7 commits into from
Jul 31, 2024
Merged

Added Basic Reservoir Model #30

merged 7 commits into from
Jul 31, 2024

Conversation

santacodes
Copy link
Collaborator

@santacodes santacodes commented Jul 22, 2024 •
edited
Loading

Subtask - #26

@santacodes santacodes mentioned this pull request Jul 22, 2024
Closed
16 tasks
Saransh-cpp
Saransh-cpp approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@Saransh-cpp Saransh-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @santacodes! Looks good to me, but I'll wait for a review from @brosaplanella.

Saransh-cpp
Saransh-cpp reviewed Jul 22, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
agriyakhetarpal
agriyakhetarpal approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@agriyakhetarpal agriyakhetarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I hope my suggestions below are in line with what you discussed you had to do in today's meeting.

pyproject.toml Outdated Show resolved Hide resolved
{{cookiecutter.project_name}}/pyproject.toml Outdated Show resolved Hide resolved
@santacodes santacodes merged commit 71d12bf into pybamm-team:main Jul 31, 2024
35 checks passed
@santacodes santacodes deleted the reservoir branch August 2, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saransh-cpp Saransh-cpp Saransh-cpp approved these changes

@agriyakhetarpal agriyakhetarpal agriyakhetarpal approved these changes

@brosaplanella brosaplanella brosaplanella approved these changes

@arjxn-py arjxn-py Awaiting requested review from arjxn-py

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@santacodes @brosaplanella @Saransh-cpp @agriyakhetarpal @arjxn-py